-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node deletionTimestamp metric #1890
Conversation
/approve Thanks for your contribution! |
@@ -57,6 +58,29 @@ func nodeMetricFamilies(allowAnnotationsList, allowLabelsList []string) []genera | |||
} | |||
} | |||
|
|||
func createNodeDeletionTimestampFamilyGenerator() generator.FamilyGenerator { | |||
return *generator.NewFamilyGeneratorWithStability( | |||
"kube_node_deletion_timestamp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to set this metric as Alpha/Experimental first, and then promote this into Stable?
Because, labels/metric name can't be changed if it's a stable metric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! @rexagod can you introduce it as experimental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, fixed.
Adds deletionTimestamp metric, for nodes. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Adds deletionTimestamp metric, for nodes.
How does this change affect the cardinality of KSM: No change (no variable labels were introduced).
Which issue(s) this PR fixes: Fixes #1889.