Add node deletionTimestamp metric #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/approve Thanks for your contribution! |
k8s-ci-robot
added
the
approved
| @@ -57,6 +58,29 @@ func nodeMetricFamilies(allowAnnotationsList, allowLabelsList []string) []genera | |||
| } | |||
| } | |||
|
|
|||
| func createNodeDeletionTimestampFamilyGenerator() generator.FamilyGenerator { | |||
| return *generator.NewFamilyGeneratorWithStability( | |||
| "kube_node_deletion_timestamp", | |||
There was a problem hiding this comment.
Do we want to set this metric as Alpha/Experimental first, and then promote this into Stable?
Because, labels/metric name can't be changed if it's a stable metric.
There was a problem hiding this comment.
Good catch! @rexagod can you introduce it as experimental?
Adds deletionTimestamp metric, for nodes. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds deletionTimestamp metric, for nodes.
How does this change affect the cardinality of KSM: No change (no variable labels were introduced).
Which issue(s) this PR fixes: Fixes #1889.